Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest attempt to fix rank mode (#1653, #1762). The rank detection method I tried before, turns out to be fairly inconsistent. So, I came up with another one. This time its direct image recognition of the rank "medals", from my testing its 100%. Obviously it'll need further testing with a beta release, but I'm pretty confident about it (assuming blizzard don't do anything stupid). It does require another library Aforge, but its not big.
Adds a new class
Utility.RankDetection
, and you callRankDetection.Match(Bitmap b)
with a screen capture param and returns:I didn't want to start dismantling all the existing rank detection stuff (wouldn't know where to start tbh :) ). So, I added the detection into
GameEventHandler.TurnStart
and seems to work.