Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opponent Names no longer show up in latest version (Apr 28, 2015) #919

Closed
Mistrelvous opened this issue Apr 28, 2015 · 7 comments
Closed

Opponent Names no longer show up in latest version (Apr 28, 2015) #919

Mistrelvous opened this issue Apr 28, 2015 · 7 comments
Labels
bug

Comments

@Mistrelvous
Copy link

When you look at past games, opponent names no longer show up. If you played a Hunter, it now just says "Hunter" and if you played Mage, it now just says "Mage" instead of user's battlenet Tag/name.
@GiggliG
Copy link

GiggliG commented Apr 28, 2015

I came here to post this issue too.
Note: names from before the update show perfectly well. For new games, HDT now seems to be storing the class name in place of opponents name.

@azeier
Copy link
Member

azeier commented Apr 28, 2015

Thanks for the clarification. Will most likely be fixed with v0.10.1 this weekend (or earlier if a more severe issue shows up).

dvide added a commit that referenced this issue Apr 29, 2015
@dvide
Fix opponent name showing as opponent class (#919)
bc7e81f
@dvide
Copy link
Contributor

dvide commented Apr 29, 2015

Think this fixes it. 022df72 was searching the key space rather than the value space of the HeroIdDict.

@azeier
Copy link
Member

azeier commented Apr 29, 2015

Looks like that should do it, yes. Thanks!

@azeier azeier mentioned this issue Apr 29, 2015
Closed
azeier pushed a commit that referenced this issue May 3, 2015
retroactively fix opponent names (#919)
d1b743b
@azeier
Copy link
Member

azeier commented May 3, 2015

All the names will now be automatically fixed with the next update, if the game has a replay attached.

@Contributor2008
Copy link

I have this issue as well. It started after a recent update, looking forward to the fix. Thanks!

@azeier azeier mentioned this issue May 5, 2015
Closed
@azeier
Copy link
Member

azeier commented May 14, 2015

fixed with v0.10.1

@azeier azeier closed this as completed May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dvide @azeier @GiggliG @Mistrelvous @Contributor2008