Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes ranks. #206

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

GrayRachnid
Copy link

Description of changes

Standardizes ranks across the board. Check changelog.

This should help make some ranks make sense.

FAQ:
Q: Why did all department heads get bumped down one instead of being given the option to choose from 2 ranks?
A: The CO needs to outrank the XO and the XO needs to outrank all the other department heads or the hierarchy would be awkward. We can't promote the XO and Captain therefore all department heads were demoted down to a rank that was never used.

Q: Physicians lost their leeway in choosing ranks, why?
A: They need to be outranked by the CMO and that's not possible if they could hop back and forth between O2 and O3. They also cannot be given access to O1 due to the medical resident role existing and occupying that rank.

Q: You are skipping out on the default E8 and E9 ranks and only using the alternative ones. Why?
A: The default E8/E9 ranks are used for any position that is not a command advisory position. E8s and E9s that are in a command advisory position tend to be a cut above the rest and therefore earn own snowflake ranks.

Q: Why the Chief Technician?
A: It seems a bit weird to me that you can be put in a leadership position but only have TN1 as an option. It's not weird to have an equivalent of a TN1 in a leadership position but it is equally likely to have a Chief in it too. It helps give the 3 roles mentioned a distinct rank just for them and allows it to highlight their importance a bit more.

Why and what will this PR improve

Makes ranks make sense.

Authorship

GrayRachnid

Changelog

🆑
bugfix: Patches a weird bug with O3 enabling people to select the S5 rank. They cannot join the round with the S5 rank but it was still misleading. My patch is hacky but it works and I did not observe any issues with it.
tweak: Physicians are now O2/S2
Tweak: All departments heads have been bumped down to O3/S3 to be under the XO.
Tweak: XO EC Rank bumped down from O5 to O4.
Tweak: The SEA now uses appropriate ranks for his command advisory positions. E8: First Sergeant E9: Sergeant Major.
rscadd: T5, Chief Technician, available to the Brig Chief, Senior Engineer and Deck Chief.
Tweak: Explorers have been given an addition rank as an option.
Tweak: Changed SC6 to SC5 since it seemed to be skipping a rank.
Tweak: Updated a few command job descriptions to reflect lore changes from.

/:cl:

@Tristan63
Copy link

897962792534040617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants