Temp table delete #1254
Open
Temp table delete #1254
+60
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from main
Merge from main
Merge from main
Merge from main
Merge from main
AndyRae
requested changes
Jan 23, 2026
AndyRae
reviewed
Jan 26, 2026
| query, parameters={"scan_report_id": scan_report_id} | ||
| ) | ||
|
|
||
| table_pairs = [(record[0], record[1]) for record in records] if records else [] |
Member
There was a problem hiding this comment.
Just to check - what is happening here?
Could you add a comment to describe it
Getting the first two values out of a list of lists is a little hard to understand why is all
| logging.error(f"Failed to update job status on skipped task: {str(e)}") | ||
|
|
||
|
|
||
| def delete_temp_tables_on_failure(context): |
Member
There was a problem hiding this comment.
I'm wondering if this should be more generic - but let's demo first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ Optimization
PR Description
This PR enables the deletion of temporary tables created when a scan report upload fails. Currently, when a scan report upload fails, the temporary tables remain in the database and overtime cause consume space.
This was tested by having the DAG timeout set to one minute, observing the logs on airflow and checking the database to ensure the tables were deleted.
Related Issues or other material
Related #1228
Closes #1228
Screenshots, example outputs/behaviour etc.