Fix Elixir Example #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was, that the examples used a binary for file name in the usage of hdr_histogram:log/3. Since the usage of this library is not elixir specific, I took the liberty of removing the example from the README. I also applied common elixir code styles to the best of my knowledge.
|
So much Elixier! Merging. Do you think it'd be useful to have this available in hex/mix? |
|
Tagged 0.3.2. |
|
that would be great. I'm quite new to the Elixir ecosystem, but I'm happy to take a look into what we need to do and provide a PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was, that the examples used a binary for file name in the usage of
hdr_histogram:log/3(see http://elixir-lang.org/getting-started/binaries-strings-and-char-lists.html).Since the usage of this library is not Elixir specific, I took the liberty of removing the example from the README. I hope that's okay.
I also applied common elixir code styles to the best of my knowledge.