Skip to content

Conversation

@jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Oct 24, 2021

No description provided.

@jonhoo jonhoo mentioned this pull request Oct 24, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #103 (112d595) into master (9c09314) will decrease coverage by 7.71%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/serialization/v2_deflate_serializer.rs 52.63% <0.00%> (-5.27%) ⬇️
src/serialization/tests.rs 96.84% <0.00%> (-3.16%) ⬇️
src/lib.rs 82.84% <0.00%> (-0.72%) ⬇️
src/errors/mod.rs 0.00% <0.00%> (ø)
tests/quantile.rs
src/tests/subtract.rs
tests/iterators.rs
tests/auto_resize.rs
tests/interval_log.rs
src/tests/value_calculation.rs
... and 13 more

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jan 30, 2022

@marshallpierce Looks like there's a legitimate failure on Windows here related to base64 — do you have any insight into what might be going wrong here? Relevant code:

let serialized_histogram =
base64::decode_config(ilh.encoded_histogram(), base64::STANDARD).unwrap();

@jonhoo jonhoo merged commit fcda222 into master Jan 30, 2022
@jonhoo jonhoo deleted the ci branch January 30, 2022 00:43
@marshallpierce
Copy link
Collaborator

Hmm... some shenanigans with windows line endings or something like that perhaps?

Any recommendations on how to get a useful Windows system for debugging?

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jan 30, 2022

I've had luck with Microsoft's Windows development environment virtual machines in the past. They're official and free.

@marshallpierce
Copy link
Collaborator

Ah, I used those in the bad old days when IE compatibility matters. They're 20GB now? wow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants