hdr_historgram_log: fix 3 memory leaks on histogram-counts #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzer from #120 found some leaks when the
hdr_decode_compressed*
functions callhdr_init
but later fails and cleans uph
by way ofhdr_free(h)
. The problem is that thecounts
field on the histogram is leaked, which is allocated here:HdrHistogram_c/src/hdr_histogram.c
Line 424 in 8dcce8f
counts
field here:HdrHistogram_c/src/hdr_histogram.c
Line 437 in 8dcce8f
Instead of using
hdr_free
the cleanup function should be `hdr_close:HdrHistogram_c/src/hdr_histogram.c
Lines 445 to 451 in 8dcce8f