Add options to the Fs.rmdir/rmdirSync functions#167
Merged
Gama11 merged 1 commit intoHaxeFoundation:masterfrom Jun 22, 2020
cedx:feature/fs_rmdir_options
Merged
Add options to the Fs.rmdir/rmdirSync functions#167Gama11 merged 1 commit intoHaxeFoundation:masterfrom cedx:feature/fs_rmdir_options
Fs.rmdir/rmdirSync functions#167Gama11 merged 1 commit intoHaxeFoundation:masterfrom
cedx:feature/fs_rmdir_options
Conversation
Gama11
reviewed
Jun 22, 2020
Author
|
Thanks @Gama11 |
terurou
added a commit
to DenkiYagi/hxnodejs
that referenced
this pull request
Jan 14, 2026
* Update Module to v12 (HaxeFoundation#156) * update * Change to Dynamic * Fix Module * Fix Require Co-authored-by: ahu <ahuglajbclajep@gmail.com> * Update Assert to v12 (HaxeFoundation#157) * update assert extern * update comments * change to string|error from string * fixed miss * update typedef types comments * update comment * Review * update assert extern * update assert extern * update assert extern * Review feedback * Fix indent * Fix typing * Add strict-mode * Revert Promise<Dynamic> * add Assert strict mode * Fix strict assert Co-authored-by: 秋津 早苗 <akitsu-sanae@users.noreply.github.com> Co-authored-by: takashiski <takashiskibb@gmail.com> * Fix callback style (HaxeFoundation#158) * Server#close callback will give an error (HaxeFoundation#154) * Server#close callback will give an error * Use imported Error * Fix a TYPO * Enable sortImports on save * Update copyright headers to 2020 * Fix untyped __js__ deprecation warnings with Haxe 4.1.0 nightlies * Haxelib release 12.0.0 * add missing methods which are causing issues in haxe.zip.Reader * add @nadako's Uncompress code * change final to var for haxe 3 compatibility * Include hxnodejs.png in Haxelib releases * Suppress some deprecated warnings. (HaxeFoundation#155) Co-authored-by: akitsu-sanae <akitsu.sanae@gmail.com> * Add version & license readme badge Use badgen.net as universal badge provider. * Add downloads badge * LICENSE -> LICENSE.md * Add the `File.append()` method. (HaxeFoundation#166) Fixes HaxeFoundation#120. * Haxelib release 12.1.0 * Fix invalid file path in Release.hx * Add options to the `Fs.rmdir/rmdirSync` functions (HaxeFoundation#167) * Make static the instance methods of module `js.node.Os`, fixes HaxeFoundation#168 (HaxeFoundation#169) * Fix Https.get() / request() calls without options, closes HaxeFoundation#170 * add size to the datagram socket "message" remote info * add missing ppid, release and report to Process * use right type (Err => Error) * Fix `sys.FileSystem.absolutePath` (HaxeFoundation#182) Previously, on Linux, `absolutePath("C:\\file")` would simply add `C:\file` to the current working directory. This was inconsistent with other Haxe targets. Now, it simply returns `C:\file`. * Implement `sys.io.File.update()` method (HaxeFoundation#180) * Fix behaviour of FileInput.eof() (HaxeFoundation#181) * Fix behaviour of FileInput.eof() Used the c# implementation for reference, now it passes the sys tests in the compiler repository * Remove trailing underscores * Add null case to `Sys.putEnv()` (HaxeFoundation#179) * Add slash to `Sys.getCwd()` like other sys targets (HaxeFoundation#183) * writeReport returns string * individual fields of Release are optional * fix optional fields * Change deprecated '@:enum abstract' to 'enum abstract' to get rid of warnings (HaxeFoundation#190) Co-authored-by: Kalle Kromann <Kalle.Kromann@laerdal.com> * Haxelib release 12.2.0 * 本家由来の新モジュールに jsImport 対応を適用 * fix: enum abstract は @:js.import の対象にできないため class に変更 --------- Co-authored-by: terurou <terurou@denkiyagi.jp> Co-authored-by: ahu <ahuglajbclajep@gmail.com> Co-authored-by: 秋津 早苗 <akitsu-sanae@users.noreply.github.com> Co-authored-by: takashiski <takashiskibb@gmail.com> Co-authored-by: Kevin Leung <kevinresol@users.noreply.github.com> Co-authored-by: Jens Fischer <jensfischer95@gmail.com> Co-authored-by: P.J.Shand <pete@peteshand.net> Co-authored-by: Dan Korostelev <nadako@gmail.com> Co-authored-by: akitsu-sanae <akitsu.sanae@gmail.com> Co-authored-by: Dario Vladovic <d.vladimyr@gmail.com> Co-authored-by: Cédric Belin <cedric@belin.io> Co-authored-by: lublak <44057030+lublak@users.noreply.github.com> Co-authored-by: tobil4sk <tobil4sk@outlook.com> Co-authored-by: k <k@klabz.org> Co-authored-by: Kalle Kromann <kallekro@gmail.com> Co-authored-by: Kalle Kromann <Kalle.Kromann@laerdal.com> Co-authored-by: FAL <contact@fal-works.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js v12.10.0 added some options to the
fs.rmdirandfs.rmdirSyncfunctions allowing to delete a directory recursively. It's a really nice addition (i.e. no need to rely anymore on custom code or third party package)!https://nodejs.org/dist/latest-v12.x/docs/api/fs.html#fs_fs_rmdir_path_options_callback