Skip to content

Remove deprecated warnings#159

Closed
akitsu-sanae wants to merge 2 commits intoHaxeFoundation:masterfrom
akitsu-sanae:remove-url-deprecated-warnings
Closed

Remove deprecated warnings#159
akitsu-sanae wants to merge 2 commits intoHaxeFoundation:masterfrom
akitsu-sanae:remove-url-deprecated-warnings

Conversation

@akitsu-sanae
Copy link
Contributor

I removed Url.hx and Domain.hx's deprecation warnings.

before:

$ haxe build.hxml
src/js/node/Url.hx:61: characters 32-41 : Warning : This typedef is deprecated in favor of { ?slashes : Null<Bool>, ?search : Null<String>, ?query : Null<haxe.extern.EitherType<String, haxe.DynamicAccess<String>>>, ?protocol : Null<String>, ?port : Null<String>, ?pathname : Null<String>, ?path : Null<String>, ?href : Null<String>, ?hostname : Null<String>, ?host : Null<String>, ?hash : Null<String>, ?auth : Null<String> }
src/js/node/Url.hx:83: characters 91-100 : Warning : This typedef is deprecated in favor of { ?slashes : Null<Bool>, ?search : Null<String>, ?query : Null<haxe.extern.EitherType<String, haxe.DynamicAccess<String>>>, ?protocol : Null<String>, ?port : Null<String>, ?pathname : Null<String>, ?path : Null<String>, ?href : Null<String>, ?hostname : Null<String>, ?host : Null<String>, ?hash : Null<String>, ?auth : Null<String> }
src/js/node/domain/Domain.hx:34: characters 24-35 : Warning : This typedef is deprecated in favor of { domainThrown : Bool, domainEmitter : js.node.events.IEventEmitter, domainBound : haxe.Function, domain : js.node.domain.Domain }
$

after:

$ haxe build.hxml
$

related is #155

@Gama11
Copy link
Member

Gama11 commented Mar 25, 2020

Well, this doesn't just remove deprecation warnings, it removes APIs people might still be using... So #155 seems like a better workaround.

@Gama11
Copy link
Member

Gama11 commented Apr 16, 2020

I merged #155 instead.

@Gama11 Gama11 closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants