[java] support --java-lib <directory> #9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It only just now occurred to me that this might break the "load a directory of class files" feature: Should add some tests... |
|
Does this work well with the compilation server? |
Simn
added
platform-java
|
Um... not sure how it would impact the server, it's just "CLI syntax sugar"? |
|
The server tries to avoid some I/O so that we don't have to read things on every request. I'll have to check how to make that work with a directory-based approach. |
|
Ah, but it does check the mtime of the jar files I hope? :) |
Gama11
force-pushed
the
java-lib-directory
branch
from
0061f58 to
ef84e24
Compare
|
Regarding the "load a directory of class files" feature, I'll just adjust the CLI help since that doesn't even seem to work without this PR right now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.