Add some thread tests (and fix eval) #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The threads test randomly hang on HL OS X. I can't tell if this is a problem with HL or with my tests. For now I'll disable them completely and just commit the eval fixes. |
back2dos
pushed a commit
to back2dos/haxe
that referenced
this pull request
Oct 5, 2021
* keep track of who owns a mutex * factor out and fix Deque * use a proper Deque for thread messaging * turns out readMessage is actually static * try to run some threads tests * casing is important you dirty Windows peasant * add Deque test * disable Deque test for Java * allow lock timeout * use less threads because AppVeyor chokes * don't run thread tests for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests! The Deque test is disabled on HL (no Lock implementation) and Java (because it fails there).