Merged
Conversation
Simn
reviewed
Apr 4, 2025
std/js/lib/NativeString.hx
Outdated
| **/ | ||
| @:overload(function(pattern:RegExp, replacement:String):String {}) | ||
| @:overload(function(pattern:RegExp, replacement:String->String):String {}) | ||
| @:overload(function(pattern:String, replacement:String->String):String {}) |
Member
There was a problem hiding this comment.
I would like to avoid this syntax for new additions.
Contributor
Author
There was a problem hiding this comment.
Is there a way to have "real overloads" share documentation?
Member
There was a problem hiding this comment.
Hmm, I guess that's what @see is for, though I'm not sure how you'd point to the right thing here.
Contributor
Author
There was a problem hiding this comment.
I'd like to go ahead with @:overload for now, and rewrite that later when we have a solution for documentation
Contributor
Author
|
So.. let's merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11904
Closes #8633 (included the commits from there here)
This is not a solution for the general case; removing special handling for untyped cast in null safety would be the way to go to unify behavior between first compilation and compilation with hxb roundtrip.