[CI] Enable sys tests for NodeJS#10437
Conversation
54ddc9f to
a0e55a3
Compare
|
Looks like this needs a few more fixes. |
|
@Simn I submitted another PR to fix the issue with |
|
Thanks, just to clarify these are the other two PRs that will need to be merged as well apart from that one: |
|
|
|
That particular file already has a lot of conditional compilation for stuff not working on various targets. Feel free to do that for this case as well for the time being. That way we can merge this PR now and track the issue in an issue. |
|
Disabled it on Mac, and mentioned the issue in the checklist #10436. Might be good for those to be moved into separate issues in |
|
CI finally behaved. Thank you for this contribution! |
|
Great, thanks for your time! |
Addresses #10436 partially.
Previously, the
sysapi tests for nodejs were not running. This PR enables most of them, apart from those that cannot be enabled currently becausesys.io.Processandsys.net.Socket.bind()are not implemented inhxnodejs.These hxnodejs PR need to be merged so that the tests run successfully:
updatemethod to File api hxnodejs#180sys.FileSystem.absolutePathhxnodejs#182