DCE not working correctly?

[ncannasse]

Thanks to @markknol I checked the output of the following Heaps empty project:

class Main extends hxd.App {
   static function main() new Main(); 
}

haxe -lib heaps -main Main -dce full

Some unused shaders are kept by the DCE, such as h3d.shader.VolumeDecal , that might have to do with macros, to investigate further.

[ncannasse]

Same with h2d.Graphics which is not produced by macros.

[nadako]

One of (?) the issues i reduced from this is the following:

class C {
	public var a = 0;
	public var b(get,never):Int;
	function get_b() return 0;
}

compiling this with -dce full keeps the C class:

// Generated by Haxe 4.0.0 (git build development @ 392806ae8)
(function () { "use strict";
var C = function() {
};
})();

the -D dce-debug says [DCE] Entry point: C.new

[RealyUniqueName]

That C example indeed looks like a consequence of my changes.

[RealyUniqueName]

However my DCE changes already exist in 3.4.4, which doesn't have this issue. The only change not released yet is #6181

[RealyUniqueName]

I've checked 3.4.4 + that change and I confirm it is the reason of this issue.

[ncannasse]

Could you either look into it soon or revert your changes until the breaking examples are fixed ?

[nadako]

It's probably a little too late to revert because of further dce work done on top of it, we should just look into it.

[RealyUniqueName]

I'll take a look today

[RealyUniqueName]

Ok, i was on development compiler when i thought i was using 3.4.4+my changes.
Now i've checked 3.4.4+#6181 for sure and the bug is not reproducible with such setup.
I keep looking.

[RealyUniqueName]

The bug was introduced in this commit: 2ee49de