Math.floor issue

[ncannasse]

class Test  {

    var px:Int = Math.floor(20);

    public function new () {        
        trace(Math.floor(20));
        trace(px); 
    }

    static function main() {
        new Test();
    }

}

This trace 0 in Neko, not sure why

[Simn]

What's the deal with these Math neko "implementations"? https://github.com/HaxeFoundation/haxe/blob/development/std/neko/_std/Math.hx#L43

This happens because we try to inline static calls if we need a constant expression.

[ncannasse]

The prototype is overridden in init, what are you suggesting to prevent this inlining ?

[Simn]

No idea, Math.hx on neko is in some weird purgatory between being extern and not...

[Simn]

See linked commit for my suggestion on how to approach this. The idea is to make Math itself extern so the compiler doesn't get funny ideas about inlining things, then provide the actual implementation in a @:native("Math") class MathImpl.

[ncannasse]

@Simn seems good

[ncannasse]

I have a similar issue when HL, I would like to prevent all @:hlNative methods to be inlined.

[Simn]

I don't really like this inlining of static calls to fields that are not marked as inline. Do you think we should just remove it?

[ncannasse]

Any context when it was added ?

[Simn]

It's quite old: #926