Fix FlxBitmapText alignment with changing text width #3548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ignore failing CI, I created an issue in hscript, here: HaxeFoundation/hscript#161 |
Geokureli
reviewed
Jan 14, 2026
Member
|
Thanks! game looks cool, too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CENTER alignment is off for flxbitmaptext after changing the text.
before the change, changing the text resulted in the text to look off-center
see the 'Upgrades' text on the top, this gif is prior to the change
change it to call getLineWidth on the line rather than use the pre-stored line widths so the new text can be aligned properly
it may be better to simply update the
_linesWidthupon changing the text, but this seems to fix in this case