Skip to content

check cliprect changes earlier #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

check cliprect changes earlier #3387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d739664
check cliprect changes earlier
Geokureli Mar 5, 2025
1d5821b
trigger CI again
Geokureli Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions flixel/FlxSprite.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,26 +803,26 @@ class FlxSprite extends FlxObject
*/
override public function draw():Void
{
checkClipRect();

checkEmptyFrame();

if (alpha == 0 || _frame.type == FlxFrameType.EMPTY)
return;

if (dirty) // rarely
calcFrame(useFramePixels);

checkClipRect();

for (camera in getCamerasLegacy())
{
if (!camera.visible || !camera.exists || !isOnScreen(camera))
continue;

if (isSimpleRender(camera))
drawSimple(camera);
else
drawComplex(camera);

#if FLX_DEBUG
FlxBasic.visibleCount++;
#end
Expand All @@ -839,7 +839,8 @@ class FlxSprite extends FlxObject
*/
function checkClipRect()
{
if ((clipRect == null && Math.isNaN(_lastClipRect.x))
if (frames == null
|| (clipRect == null && Math.isNaN(_lastClipRect.x))
|| (clipRect != null && clipRect.equals(_lastClipRect)))
return;

Expand Down