Enumerate FlxBasic.ID #2266
Closed
Enumerate FlxBasic.ID #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gama11 any reason why we shouldn't merge this? |
|
Technically it could be considered a breaking change in case somebody relies on the current default value in some way, but it's probably not too much of an issue. |
|
Reimplemented this (see linked commit) to fix some stylistic issues, as well as hide the new field from completion and provide a better doc comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now
FlxBasic.IDis unused and not really set up well. We should at least make IDs unique so that people can use them in their own games without having to set them manually.