Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing bigint constants #707

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: missing bigint constants #707

merged 1 commit into from
Dec 20, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 19, 2024 •
edited
Loading

Motivation

Some constants were missing to be updated from number to bigint.

Acceptance Criteria

  • Change constants from 0 to 0n.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@glevco glevco self-assigned this Dec 19, 2024
@glevco glevco marked this pull request as ready for review December 20, 2024 00:27
@glevco glevco merged commit 95c602f into release-candidate Dec 20, 2024
2 checks passed
@glevco glevco deleted the fix/bigint branch December 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@tuliomir tuliomir tuliomir approved these changes

Assignees

@glevco glevco

Labels
None yet
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glevco @tuliomir @pedroferreira1