Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 3 columns in the methods list #702

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

pedroferreira1
Copy link
Member

Context

Depending on the length of the method names, the UI is still not good with 5 columns. I changed to 3 columns only, which fits well the blueprints we have nowadays. If the method names are too big, it will still break but this is unlikely because they are also code method names, which shouldn't be too big, so I think it's safe to go with this solution for now.

Acceptance Criteria

  • Use only 3 columns to list the available methods of a nano contract.

Old UI:

image

New UI:

image

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 merged commit cd2142f into master Dec 10, 2024
2 checks passed
@pedroferreira1 pedroferreira1 deleted the fix/nc-methods branch December 10, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants