Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet for Ubuntu 24.04 with backward compatibility #672

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Oct 16, 2024

Acceptance Criteria

  • Add appropriate AppArmor profile
  • Add script to install the profile on app installation
  • Add script to remove the profile on app removal
  • It should be backward compatible with previous ubuntu versions

Closes https://github.com/HathorNetwork/internal-issues/issues/392

Warning

The AppImage target is not addressed in this fix because it doesn't support after install script execution, which is required for the fix.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Oct 16, 2024
@alexruzenhack alexruzenhack removed the request for review from r4mmer October 16, 2024 16:24
package.json Show resolved Hide resolved
build_resources/linux/apparmor-profile Outdated Show resolved Hide resolved
@alexruzenhack alexruzenhack requested a review from luislhl October 24, 2024 18:12
@alexruzenhack alexruzenhack merged commit 0e92946 into master Oct 24, 2024
1 check passed
@alexruzenhack alexruzenhack deleted the fix/ubuntu-24.04 branch October 24, 2024 23:23
@tuliomir tuliomir mentioned this pull request Oct 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants