Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show network tokens on token bar #639

Merged
merged 5 commits into from
Jul 9, 2024
Merged

feat: show network tokens on token bar #639

merged 5 commits into from
Jul 9, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Jun 28, 2024 •
edited
Loading

Acceptance Criteria

  • Register any custom token that comes from the network /version api (under key custom_tokens).
  • Always show the network tokens on the token bar

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Jun 28, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner June 28, 2024 19:13
@r4mmer r4mmer force-pushed the feat/network-custom-tokens branch from 0260365 to 5207126 Compare July 3, 2024 17:15
@r4mmer r4mmer requested a review from tuliomir July 4, 2024 14:49
pedroferreira1
pedroferreira1 approved these changes Jul 5, 2024
View reviewed changes
src/actions/index.js Show resolved Hide resolved
@r4mmer r4mmer merged commit bfd5b87 into master Jul 9, 2024
1 check passed
@r4mmer r4mmer deleted the feat/network-custom-tokens branch July 9, 2024 13:24
r4mmer added a commit that referenced this pull request Jul 9, 2024
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/decimal-places…
d9a16a8 
…-config

* origin/master:
  feat: show network tokens on token bar (#639)
@pedroferreira1 pedroferreira1 mentioned this pull request Jul 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@tuliomir tuliomir tuliomir approved these changes

Assignees

@r4mmer r4mmer

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4mmer @tuliomir @pedroferreira1