Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet start error when running on fullnode #365

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Oct 26, 2023

Acceptance Criteria

  • Fix error handling when starting wallet on fullnode
  • Add reset button in the LoadWalletErrorScreen
  • Update localization base text and translate to pt-br

Related to Infinity load when the network version can't be verified, which is fixed in the lib by HathorNetwork/hathor-wallet-lib#584.

Warning

I left empty all the translations related to WalletConnect and DevSettings because it is being handled in another PR.

ds-fix-start-error.mp4

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Oct 26, 2023
@alexruzenhack alexruzenhack added the bug Something isn't working label Oct 27, 2023
src/sagas/wallet.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
- It should allow a user to reset their wallet in case the network it operates on is not longer function.
locale/da/texts.po Show resolved Hide resolved
src/screens/LoadWalletErrorScreen.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants