Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During manual testing with the updated wallet-headless, I found a bug in the logic used to revive BigInts. We should check using JS
Number.MAX_SAFE_INTEGER
, instead.Acceptance Criteria
bigIntReviver()
a standalone function in theJSONBigInt
object.bigIntReviver()
uses to determine when it should return aBigInt
.Security Checklist