Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow private networks #286

Merged
merged 3 commits into from
Nov 11, 2021
Merged

feat: allow private networks #286

merged 3 commits into from
Nov 11, 2021

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Nov 11, 2021

Acceptance Criteria

  • It should be possible to use this version of the lib in our Explorer and make it work with private-networks

Notes

  • We are using the same version bytes as the Testnet for the private networks, because we would have problems with TxMiningService if using different ones, since it validates the addresses.

TODO

@luislhl luislhl self-assigned this Nov 11, 2021
@luislhl luislhl requested a review from msbrogli November 11, 2021 16:06
@luislhl luislhl changed the base branch from master to dev November 11, 2021 16:08
@luislhl luislhl mentioned this pull request Nov 11, 2021
Closed
4 tasks
@luislhl luislhl merged commit bbb019e into dev Nov 11, 2021
@luislhl luislhl deleted the feat/allow-private-networks-2 branch November 11, 2021 23:48
@luislhl luislhl mentioned this pull request Nov 11, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees

@luislhl luislhl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luislhl @msbrogli @pedroferreira1