Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Support for providing of parameters at path level and overriding them… #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

portnov
Copy link

@portnov portnov commented Feb 6, 2022

… at operation level.

This should fix #17.

@portnov portnov changed the title Support for providing of parameters at path level and overriding them… (WIP) Support for providing of parameters at path level and overriding them… Feb 6, 2022
Copy link
Member

@joel-bach joel-bach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, I would definitely like to merge it!
Could you regenerate the golden files (see https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator#development) and maybe also check if the example code has changed?
At least the golden part is needed to get CI passing.

@portnov
Copy link
Author

portnov commented Feb 8, 2022

Yes, thanks to tests I already see one bug (due to use of Data.Map parameters can be incorrectly reordered). I intend to fix tests this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parameters on Path Item level
2 participants