Repository navigation
chore: pin the harperdb peer range to Harper 4 (<5.0.0) - #214
Conversation
The 1.x line is Harper-4-only — its assumptions about the runtime session model (e.g. request.session being the live hdb_session instance with a working .delete()) do not hold on Harper 5, where request.session is a shallow copy. Constrain the peer range so 1.x can't be installed against Harper 5. (harperdb npm tops out at 4.7.x today — Harper 5 ships as the `harper` package — so this is explicit intent / future-proofing.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxkByn5VD9Mwh7Pm9wtmBH
|
3 blockers found. 1. Missing version bumpFile: 2. Lockfile driftFile: 3. Missing CHANGELOG.md entryFile: 4. Documentation drift (Internal)File: |
heskew
left a comment
There was a problem hiding this comment.
Review at 47c4bba: no blockers.
The peer range does what the PR intends: it includes supported Harper 4 releases from 4.6.0 and rejects 5.x. Consumers receive package.json, so the published compatibility boundary is effective.
Two low, non-blocking consistency cleanups:
- package-lock.json:29 still records the root peer as >=4.6.0. Please regenerate or edit the root lock metadata to match >=4.6.0 <5.0.0.
- CLAUDE.md still documents the peer as harperdb (>=4.6.0); please update it with the Harper-4 upper bound.
A version bump and changelog entry belong in the separate release PR, consistent with the repository workflow. The red review job is reviewer-action infrastructure; Node 22/24, Bun, lint/build/test, validation, and security checks are green.
The 1.x line is Harper 4-only. Its runtime assumptions don't hold on Harper 5 — e.g.
request.sessionis the livehdb_sessioninstance (with a working.delete()) on Harper 4, but a shallow copy (no.delete) on Harper 5. Constrain the peer range so 1.x can't be installed against Harper 5.peerDependencies.harperdb:>=4.6.0→>=4.6.0 <5.0.0.Note:
harperdbon npm tops out at 4.7.x (Harper 5 ships as theharperpackage), so this is explicit-intent / future-proofing rather than closing a live install path — but it documents the support boundary and guards against a futureharperdb@5.Base branch is
v1.x.