Skip to content

Harden SENSITIVE_KEY_PATTERN log redaction for snake_case secret keys #140

Closed

Description

@heskew

src/index.ts redactSecrets uses SENSITIVE_KEY_PATTERN to redact secrets before logging the plugin options blob. It matches the camelCase config keys in use today (clientSecret, signingKeyPem, initialAccessToken) but not snake_case variants (private_key, initial_access_token, signing_key_pem).

Defense-in-depth: broaden the regex to also catch snake_case, e.g. /secret|signing_?key_?pem|initial_?access_?token|private_?key|password/i. Over-redaction in a log is safe, so the downside is nil.

Low priority / hardening. Surfaced by the gemini-review bot on #134 (src/index.ts:20).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions