Repository navigation
test(windows): add redirect tests to API integration test suite - #545
Closed
claude[bot] wants to merge 1 commit into
Closed
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
Adds 25_redirectTests.mjs to the apiTests testSuite, covering redirector component deployment, CSV rule seeding, redirect lookups, 404 for unknown paths, and Rule table listing. The local-fixture deployment path works cross-platform without Windows-specific handling. Wires the new file into testSuite.mjs so it runs on Windows via run-integration-apiTests-windows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Reviewed; no blockers found. |
Contributor
|
Closing — the scope of #525 was actually about un-skipping existing Windows-skipped tests (continuing the pattern from #528), not adding new minimal redirect tests in the apiTests/ suite. The redirect coverage in Filing a new issue with sharper scope to avoid stomping on the framing of #525. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integrationTests/apiTests/tests/25_redirectTests.mjs— a new redirect test file in the apiTests (old-style) suitetemplate-redirector-3.0.1.tgzfixture viadeploy_component, polls for the/Rule/endpoint to confirm readiness, seeds redirect rules via CSV, then tests lookups and 404 behaviortestSuite.mjsso it runs on Windows via therun-integration-apiTests-windowsCI jobdeploy_componentwithpackage) works cross-platform without any Windows-specific handlingTest plan
npm run format:checkpasses (no issues in changed files)npm run lintshows no new issues in the changed filesrun-integration-apiTests-windowsCI job picks up the new tests and they pass on Windowsrun-integration-apiTests(Linux) CI job also passes with the new testsCloses #525