Skip to content

Enforce the dropTable cross-worker-write reproducer; close #1381, #2496 #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriszyp merged 3 commits into from
Oct 9, 2026
Merged

Enforce the dropTable cross-worker-write reproducer; close #1381, #2496 #2955

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f490bc
Enforce the dropTable cross-worker-write reproducer unconditionally
kriszyp Oct 1, 2026
359c838
Point back at rocksdb-js#850 from the now-unconditional reproducer
kriszyp Oct 1, 2026
f9268f7
Trim the rocksdb-js#850 comment to one line
kriszyp Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions unitTests/resources/dropTableCrossWorkerWrite.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ require('../testUtils');
const assert = require('node:assert');
const path = require('node:path');
const { setupTestDBPath } = require('../testUtils');
const { table, database } = require('#src/resources/databases');
const { table } = require('#src/resources/databases');
const { startWorker, onMessageByType, setMainIsWorker } = require('#js/server/threads/manageThreads');

const WORKER_FIXTURE = path.join(__dirname, 'dropTableCrossWorkerWrite-worker.js');
Expand Down Expand Up @@ -115,11 +115,8 @@ describe('dropTable racing a cross-worker source-fill commit', function () {
assert.deepStrictEqual(catalogRows(Main, name), [], 'catalog rows must be removed');
});

// Relies on @harperfast/rocksdb-js deferring physical column-family drops behind admitted commits (rocksdb-js#850).
it('leaves the storage environment writable and the catalog clean', async function () {
assert.ok(
'columnFamily.pendingReclaims' in (database({ database: 'test', table: null }).getStats?.() ?? {}),
'the drop path no longer drains in-flight writes and needs a @harperfast/rocksdb-js that defers physical column-family drops behind admitted commits (rocksdb-js#850); bump the pin'
);
let raced = 0;
for (let i = 0; i < ITERATIONS; i++) {
const name = `CrossDrop${i}`;
Expand Down
Loading