Repository navigation
test(ci): drop startup-timeout workarounds, now handled by integration-testing 0.5.x (#1139) - #1149
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the @harperfast/integration-testing dependency in package.json from version ^0.3.1 to ^0.5.0 under devDependencies. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
|
Reviewed; no blockers found. |
kriszyp
approved these changes
Jun 5, 2026
Contributor
Author
…x idle-timeout handles slow boots (#1139)
heskew
force-pushed
the
ci/harness-race-fix-1139
branch
from
June 12, 2026 20:27
341b8aa to
2756912
Compare
heskew
changed the title
heskew
marked this pull request as ready for review
June 12, 2026 20:29
kriszyp
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
@harperfast/integration-testing@0.5.1now onmain(#1268), startup readiness uses an idle timeout (resets on each chunk of output) instead of a single wall-clock deadline — so theHARPER_INTEGRATION_TEST_STARTUP_TIMEOUT_MS=120000/180000overrides are no longer needed. Removes both (Linux + Windows). Last piece of #1139.🤖 Generated with Claude Code