Skip to content

unitTests/dataLayer/harperBridge/** (28 files) runs in no CI leg and fails at load #2863

Description

@kriszyp

unitTests/dataLayer/harperBridge/** — 28 test files — runs in no CI leg at all, and would fail at load if it did.

It runs nowhere

Enumerated every leg on main @ 576d33330:

  • package.json:73 — test:unit:main explicitly --exclude "unitTests/dataLayer/harperBridge/**/*".
  • package.json:85 — test:unit:dataLayer excludes it too.
  • No other leg's glob reaches it, and unitTests/windowsGate.mjs GROUPS / EXCLUDED never mention harperBridge or dataLayer.

After enumerating all of them, this is the only orphaned subtree in the repo.

It also fails at load

The suites read systemSchema.hdb_schema / .hdb_table / .hdb_attribute (resourceDeleteRecordsBefore.test.js:114-124, lmdbCreateAttribute.test.js:90-97), but json/systemSchema.json no longer defines those keys.

Secondary, and the reason this is easy to trip over: the bare glob unitTests/dataLayer/**/*.js (unlike test:unit:dataLayer) pulls these files in, and lmdbDeleteAuditLogsBefore.test.js:21 + lmdbWriteTransaction.test.js:42 require('#src/dataLayer/CreateTableObject') without the .default unwrap that 11+ sibling files use, then new it at module scope — so the require itself throws CreateTableObject is not a constructor.

Why this needs a decision rather than a delete

It is not dead code: dataLayer/harperBridge/harperBridge.ts backs insert, delete, SQLSearch, schema, readAuditLog and getBackup. So the choice is retire the suite (and accept that those paths are untested) or repair it (fix the fixture and the require shape, then put it in a leg). Either is fine; the current state — 28 files that look like coverage and are not — is not.

Re-verified on origin/main @ 576d33330 on 2026-09-22.

— Claude Opus 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P2

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions