Skip to content

[CONTROL - do not merge] Measure whether #732's regression test fails on base #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kriszyp wants to merge 2 commits into from
Closed

[CONTROL - do not merge] Measure whether #732's regression test fails on base #741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ff438
CONTROL (do not merge): neutralize the #732 ownership guard to measur…
kriszyp Aug 20, 2026
7cb6a55
re-trigger: second control data point for the fails-on-base measurement
kriszyp Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions replication/replicationConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@
logger.warn?.(`[test] forcing open-but-idle replication wedge for db "${databaseName}" (harper-pro#420)`);
ws.terminate = () => {};
ws.close = () => {};
ws._socket?.pause();

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Unit Tests (Node.js v24) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Unit Tests (Node.js v26) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Unit Tests (Node.js v22) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Build Harper Pro (Node.js v24) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Build Harper Pro (Node.js v26.5.0) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / Build Harper Pro (Node.js v22) 

Property '_socket' does not exist on type 'WebSocket'.

Check failure on line 1003 in replication/replicationConnection.ts

View workflow job for this annotation

GitHub Actions / YCSB single-node (Node.js v24) 

Property '_socket' does not exist on type 'WebSocket'.
return true; // tell the watchdog to treat this connection's byte count as frozen
}

Expand Down Expand Up @@ -6313,12 +6313,10 @@
// creates and attaches its stream. Without this post-attach ownership check, the orphaned
// source has no producer or connection timer left and an in-place repair holds its file lock
// until core's long source-idle timeout. Fail it now so the next connection can repair it.
abortLateBlobReceiveAfterClose(
isConnectionSuperseded(wsClosed, options.connection, ws),
stream,
remoteNodeName,
blobId
);
// CONTROL BRANCH ONLY — do not merge. Hardcoded false neutralizes the #732 ownership
// guard so production behavior equals origin/main, while leaving the exported function
// (and its unit tests) intact. Measures whether the regression test fails on base.
abortLateBlobReceiveAfterClose(false && isConnectionSuperseded(wsClosed, options.connection, ws), stream, remoteNodeName, blobId);
}
if (finished) {
// A copy-frame blob gates the copy cursor by walk position; a gapped settle clamps the
Expand Down
Loading