Skip to content

Bump core to the origin-closed timestamp floor (harper#3085), the producer half of per-origin closed floors #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriszyp merged 4 commits into from
Oct 7, 2026
Merged

Bump core to the origin-closed timestamp floor (harper#3085), the producer half of per-origin closed floors #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad5bd84
Bump core to the origin-closed timestamp floor (harper#3085)
kriszyp Oct 7, 2026
21b1bf0
Reserve the repair fixture's synthetic local-log writes against the o…
kriszyp Oct 7, 2026
c4a5573
Release the repair fixture's reservations after their commits settle
kriszyp Oct 7, 2026
ba2943b
Bump core to harper#3085's framing-path listing
kriszyp Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core
Open in desktop
Submodule core updated 15 files
+1 −0 .github/workflows/review-coverage.yml
+1 −0 DESIGN.md
+1 −1 package.json
+14 −1 resources/DESIGN.md
+64 −26 resources/DatabaseTransaction.ts
+13 −0 resources/RocksTransactionLogStore.ts
+107 −28 resources/Table.ts
+61 −0 resources/auditStore.ts
+403 −0 resources/originClosedFloor.ts
+6 −0 server/threads/manageThreads.js
+10 −2 unitTests/resources/auditLog.test.js
+4 −2 unitTests/resources/dualClockAuditRecord.test.js
+74 −0 unitTests/resources/originClosedFloor-thread.js
+127 −0 unitTests/resources/originClosedFloor.bench.js
+425 −0 unitTests/resources/originClosedFloor.test.js
26 changes: 21 additions & 5 deletions unitTests/replication/repairDeleteEchoRuns.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
RepairRefusedError,
} from '#src/replication/repairDeleteEchoRuns';
import { RocksTransactionLogStore } from '#src/core/resources/RocksTransactionLogStore';
import { releaseLocalKey, reserveLocalKey } from '#src/core/resources/originClosedFloor';

// Required, not imported: the ESM entry would evaluate a second copy of the package beside the one the
// data layer already loaded through CJS.
Expand Down Expand Up @@ -121,10 +122,16 @@ async function withDatabase(databasePath, callback) {
function writeTransactions(databasePath, transactions) {
return withDatabase(databasePath, async (db, store) => {
for (const [timestamp, records] of transactions) {
await db.transaction((transaction) => {
transaction.setTimestamp(timestamp);
for (const record of records) store.put(0, { ...record }, { transaction });
});
let handle;
try {
await db.transaction((transaction) => {
handle = transaction;
reserveLocalKey(db, transaction, timestamp);
for (const record of records) store.put(0, { ...record }, { transaction });
});
} finally {
releaseLocalKey(handle);
}
Comment thread
kriszyp marked this conversation as resolved.
}
});
}
Expand Down Expand Up @@ -290,7 +297,16 @@ describe('repairDeleteEchoRuns (harper-pro#826)', function () {
expect(Array.from(log.query({ start: T + 1 }))).to.have.length(0);
const { lastCommittedPosition, nextLogPosition } = log.getStats();
expect(lastCommittedPosition).to.not.deep.equal(nextLogPosition);
await db.transaction((transaction) => store.put(0, putOf('next', T + 1), { transaction }));
let handle;
try {
await db.transaction((transaction) => {
handle = transaction;
reserveLocalKey(db, transaction, T + 1);
store.put(0, putOf('next', T + 1), { transaction });
});
} finally {
releaseLocalKey(handle);
}
Comment thread
kriszyp marked this conversation as resolved.
expect(log.getStats().lastCommittedPosition.sequence).to.equal(2);
});
expect((await readBack(databasePath)).map(({ id }) => id)).to.deep.equal(['p', 'z', 'next']);
Expand Down
Loading