Repository navigation
Say a deploy is not test-loaded before it goes live under the default lockdown - #692
Conversation
…er the default lockdown The 5.3 release note said deploy_component validates each release before swapping it live, and the activate: false entry said a stage builds and verifies the component. Under the default applications.lockdown no node test-loads a deploy before the swap (HarperFast/harper#2893), so a release that installs but throws when it loads goes live and reports the failure in get_status. Say that where deploy_component is documented, and drop the two claims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to clarify that components are built and installed (rather than verified or test-loaded) before going live, specifically under the default lockdown settings. The feedback suggests replacing an em dash with a hyphen in the list of parameters to comply with style guidelines, and wrapping the critical warning about deployment load failures in a Docusaurus :::warning block.
From review: a release that throws at load going live is an operational caveat, so it reads as a :::warning, the form this page already uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cb1kenobi
left a comment
There was a problem hiding this comment.
The docs no longer claim that deploy_component validates or verifies a release before it goes live. The operations page now warns that under the default lockdown a throwing load is still deployed and reported in get_status, and the 5.3 note says the swap happens after build and install. Existing comments on the warning block and the list em dash were already handled. Nothing blocking remains on the changed lines.
—
Reviewed 53f89fd
Companion to HarperFast/harper#2893 (fixes HarperFast/harper#2881). Under the default
applications.lockdown: freeze-after-load, no node test-loads adeploy_componentrelease before it goes live, so two 5.3 docs claims no longer hold, and the reference now says what happens instead.reference/operations-api/operations.md:deploy_componentgains a paragraph saying a deploy is not test-loaded under the default lockdown, and that a release that installs but throws when it loads is deployed, reports the failure inget_status'scomponentStatus, and leaves the rest of the instance serving. Theactivate: falseentry says a stage builds and installs the component rather than "builds and verifies" it.release-notes/v5-lincoln/5.3.md: the staged-build note says a release is swapped live once it has built and installed, rather than "validated".Verification:
npm run buildsucceeds, andprettier --checkis clean on both files. The behavior is pinned byintegrationTests/deploy/worker-deploy-frozen-intrinsics.test.tsin HarperFast/harper#2893: a throwing candidate is activated, and after a restartget_statusreports iterrorwhile the worker keeps serving.🤖 Generated with Claude Code