Repository navigation
Document when a deploy updates the root config entry - #682
Conversation
A component's root-config entry now changes only once its new release is live, a payload deploy removes package/install/credentials from it, and startup settles an interrupted deploy's entry with its tree (HarperFast/harper#2315 step 3). Documents that on deploy_component and adds a 5.3 release note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and release notes for version 5.3.0 to explain how a deployment updates the root configuration file (harper-config.yaml) only after a release goes live. Feedback was provided to format the list of deployment types in operations.md using bold-led terms and em dashes to maintain consistency with the repository's prose list style.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-682 This preview will update automatically when you push new commits. |
…he rest of the page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-682 This preview will update automatically when you push new commits. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
This branch was previously deployed
2 participants
Documents when
deploy_componentchanges a component's entry in the rootharper-config.yaml, for HarperFast/harper#2789 (harper#2315 step 3).deploy_component. It covers that the entry changes only once the new release is live on that node, and that startup settles an interrupted deploy's entry with its tree. It also gives what each kind of deploy does to the entry: apackagedeploy replaces it, apayloaddeploy removespackage,installandcredentialsand keeps the rest, anddrop_componentremoves it. The writes are serialized withset_configuration, and a deploy that has to change the entry is refused before anything changes when the root config does not parse or its directory is not writable.Badged
v5.3.0(changed): the feature lands onmainafterv5.3.0-beta.2, andv5.3.0is not cut.Verification
npm run format:checkandnpm run buildpass, and the preview deployment renders both pages, with the release note's link landing on the new section. The section describes what HarperFast/harper#2789 implements and tests: its end-to-end test,integrationTests/deploy/root-config-activation-effect.test.ts, covers each kind of deploy anddrop_component, and its unit tests cover the serialization withset_configurationand the up-front refusal.🤖 Generated with Claude Code