-
Couldn't load subscription status.
- Fork 8
Update defining schemas page #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! And just so its clear, the reference page is just the old developers page moved to the new location? I won't review that as much here since its just a move.
versioned_docs/version-4.6/developers/applications/defining-schemas.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-4.6/developers/applications/defining-schemas.md
Outdated
Show resolved
Hide resolved
…hemas.md Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
…hemas.md Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
…on into nenne/schema-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please copy to other relevant versions and lets get this merged 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think generally looks good. I assume we may need to copy to the correct versions.
This PR updated the defining schemas page