Fix Spoiler Naming #5111
Merged
Fix Spoiler Naming #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions of constructor functions with explicit spoilerName parameters except base.
Pepe20129
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pots and fairies were still using the explicit spoiler naming convention, and thus were not matching up with all the other locations that were using
SpoilerNameFromShortName(). This adds versions of those constructor functions to pass parameters to the Location constructor that usesSpoilerNameFromShortName(), and removes all versions of the constructor functions that still had explicit spoiler name parameters exceptBase(), which is required for a just a few main locations.Also removed the explicit "GF " from the Gerudo Fortress short names.
Build Artifacts