Add hilite setup calls around all custom GI draws #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
hilite-gi-draws
branch
from
023d4fe to
d13a275
Compare
aMannus
reviewed
Feb 12, 2025
Comment on lines
+21
to
+22
| func_8002EBCC(&enElf->actor, play, 0); | ||
| func_8002ED80(&enElf->actor, play, 0); |
There was a problem hiding this comment.
Sad these don't have names in decomp yet, but it is what it is for now.
aMannus
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds hilite setup calls before all of our custom uses of GI draws.
The game normally does this before any GI draws that happen in vanilla (like in shops, heart containers, etc), but we weren't calling them in all other places that we added. The hilite calls are responsible for making the texture gen effects to not move strangely based on the player camera.
It is a little messy, and probably it would be worth having a new method that contains all the logic needed to draw GI models like this.
Build Artifacts