Fix skipping Adult Ruto one-point cutscene #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
requested changes
Nov 4, 2024
There was a problem hiding this comment.
- The change to
z_onepointdemo.cis not something that I would like us to do to the game's source. - Although this cutscene is technically a onepoint actor CS, from a user perspective the CS is much more like a story cutscene.
I think the handling for this should be moved under a story cutscene check. Additionally, we probably should just kill Ruto's actor on init and also set the scene flag switch marking the cutscene as "complete". This would avoid the need to deal with the camera.
Be mindful to only do this when in water temple, so that ruto in other scenes is unaffected.
Archez
reviewed
Nov 5, 2024
Archez
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4505
Added the hook to skip the cutscene with Adult Ruto in the Water Temple, so she simply doesn't appear.
Build Artifacts