Small Warnings Refactor #4477
Merged
Small Warnings Refactor #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
reviewed
Oct 28, 2024
There was a problem hiding this comment.
I think this looks good to me. I'm not the biggest fan of losing warnings in the game's src code because we have our own code in there too, but at least with VB we are reducing that over time.
It might be nice if we can set a cmake option to control this warning behavior so that it is easy to disable the override with a -D flag for those that want to spot check things.
|
I was actually thinking about a build flag myself. I'll set that up as I handle the feedback. |
Archez
reviewed
Oct 28, 2024
Resolve math macro duplication warnings.
… in command line to disable it. Prevet total compile option overwrite for LUS.
Malkierian
force-pushed
the
warnings-changes
branch
from
3f16d53 to
059517f
Compare
Archez
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables all warnings, even in release, on the
srcdirectory, as well as the entirety of LUS.Resolves math macro duplication warnings.
Build Artifacts