Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scene command XML parsers #4054

Merged

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Apr 18, 2024

Adds XML parsers for every scene command.
The logging methods have been left commented out on purpose to help future debugging if needed.

Build Artifacts

@briaguya-ai
Copy link
Contributor

very cool! only real comment i have is about the logging functions. i'm thinking it'd make sense to move those out of the importer files - possibly into a new resource/logging/ directory

then you could have LogActorListAsXML live in resource/logging/scenecommand/SetActorListLogger.(cpp/h) and so on

the only other part of that would be the commented out calls to log, maybe it makes sense to put those behind an #ifdef or a developer tools cvar

Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice. I do want to keep the logging functions around, I don't have a strong preference on them staying in the same file or being moved.

@briaguya-ai
Copy link
Contributor

my reasoning for wanting the logging functions moved out of the importer files is that they aren't importer specific - they work on fully parsed resources

@Pepe20129
Copy link
Contributor Author

I think it'd be better if they're all moved to somewhere like resource/logging/SceneCommandLoggers.(cpp/h) as one file each seems like overkill.

@briaguya-ai briaguya-ai merged commit 92467b8 into HarbourMasters:develop Apr 29, 2024
8 checks passed
@Pepe20129 Pepe20129 deleted the scene_command_xml_parsers branch July 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants