-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scene command XML parsers #4054
Add scene command XML parsers #4054
Conversation
very cool! only real comment i have is about the logging functions. i'm thinking it'd make sense to move those out of the importer files - possibly into a new then you could have the only other part of that would be the commented out calls to log, maybe it makes sense to put those behind an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice. I do want to keep the logging functions around, I don't have a strong preference on them staying in the same file or being moved.
my reasoning for wanting the logging functions moved out of the importer files is that they aren't importer specific - they work on fully parsed resources |
I think it'd be better if they're all moved to somewhere like |
Adds XML parsers for every scene command.
The logging methods have been left commented out on purpose to help future debugging if needed.
Build Artifacts