Fix issue with bombchus always showing as major #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer it if we did the inverse and match how we handle bottles. The item table entry would be marked as MAJOR, and then the chest display would handle downgrading it to LESSER or something. |
|
i like @Archez's suggestion |
garrettjoecox
force-pushed
the
fix-bombchu-csmc
branch
from
dc8ac62 to
574e892
Compare
Finally got around to this |
briaguya-ai
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether or not a bombchu show's as major is handled in the CSMC logic, by default it should be junk like the other bombchu items
Build Artifacts