Fix: seed srand on launch and fix spoiler log for seed testing generation #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, I assume you've tested to ensure that seeds generated in different launches and different builds generate different seeds? |
Waiting for the build result to download a release build and confirm. Will comment when my testing is done. |
|
@leggettc18 Tested with the artifacts by having a minimal shipofharkinian.json that was set to skip title (to avoid any rand calls from the title screen). Multiple launches with the same json all successfully had unique generations. |
Archez
force-pushed
the
seed-srand-and-fixes
branch
from
911b0b9 to
be0c976
Compare
leggettc18
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a call to
srand()in launch flow so that the first call torand()is unique. I figure placing this inOTRGlobals::InitOTRis sufficient for our needs (early enough in the app launch and in a visible place).I also deferred random seed generation to pass in an empty string so the 3drando code can handle the rest of the logic for setting a random seed.
There is also a fix for the multi seed testing count logic to ensure we save the seed as a string, and hash it. This is to replicate the real flow so that the seed number tracked in the spoiler log is the same string you can enter in manually (string value pre-hashed).
Build Artifacts