Feature: Allow choosing audio backend #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcvz
force-pushed
the
feature/choose-audio-backend
branch
2 times, most recently
from
66bef57 to
6caefc3
Compare
dcvz
force-pushed
the
feature/choose-audio-backend
branch
from
6caefc3 to
d70303d
Compare
Kenix3
reviewed
Sep 25, 2022
Currently it requires a reload to apply. Just like the gfx backend option. Didn't look into whether APlayer can be swapped at runtime |
Kenix3
approved these changes
Sep 26, 2022
dcvz
added a commit
to dcvz/Shipwright
that referenced
this pull request
Sep 27, 2022
* Fix X11 being searched for on macOS * Add ability to switch audio backends * Fix issues with c arrays of std dynamic size items * Fix old uses of sizeof() * Remove current selected option from list * Don’t show items if we only have one option
Closed
Kenix3
pushed a commit
to Kenix3/Shipwright
that referenced
this pull request
Oct 19, 2022
* Fix X11 being searched for on macOS * Add ability to switch audio backends * Fix issues with c arrays of std dynamic size items * Fix old uses of sizeof() * Remove current selected option from list * Don’t show items if we only have one option
dcvz
added a commit
to briaguya-ai/Shipwright
that referenced
this pull request
Nov 12, 2022
* Fix X11 being searched for on macOS * Add ability to switch audio backends * Fix issues with c arrays of std dynamic size items * Fix old uses of sizeof() * Remove current selected option from list * Don’t show items if we only have one option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to choose an audio backend and fixes the following bugs: