-
Notifications
You must be signed in to change notification settings - Fork 5
add monitoring dashboard #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6f26bce
Add labels, author avatars, and last updated timestamps to Action Req…
claude 0ace0fd
Remove unused Star import
claude f456ff0
Merge pull request #6 from ArjinAlbay/claude/resolve-github-issues-01…
ArjinAlbay ed343f6
Implement hierarchical mention priority for review requests
claude 9ff2240
Merge pull request #7 from ArjinAlbay/claude/add-monitoring-dashboard…
ArjinAlbay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Persisted ActionItem shape is not migrated (risk of crashes for existing users)
You’ve upgraded
ActionItemto:author: { login: string; avatarUrl: string }labels: Array<{ name: string; color?: string }>(required)but the store still persists
assignedItems/mentionItems/staleItemsunder the same"githubmon-action-items"key with no rehydrate migration. Existing installations may have cached items where:authoris still a plain string.labelsis missing or in an older shape.The new UI (e.g.,
item.author.login.substring(...), label rendering) assumes the new structure and can throw at runtime on first render beforerefreshDataoverwrites stale entries.Consider one of:
onRehydrateStorage(or equivalent) to normalize old entries into the new{ author, labels }shape.authorandlabelsbackward‑compatible unions and normalize them lazily on read.I’d treat this as important to fix before shipping since it affects existing users’ first render after upgrade.
I need to verify the persistence configuration and interface changes. Let me investigate the codebase.
🏁 Script executed:
Length of output: 12141
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 67
🏁 Script executed:
Length of output: 2334
Let me verify if there's any defensive coding or migration logic elsewhere:
🏁 Script executed:
Length of output: 2288
🏁 Script executed:
Length of output: 777
🏁 Script executed:
Length of output: 65
🏁 Script executed:
Length of output: 0
ActionItem persistence schema mismatch confirmed—no migration for breaking changes
Verified: The store persists
assignedItems,mentionItems, andstaleItemsto"githubmon-action-items"with:authorchanged from string to required{ login: string; avatarUrl: string }labelsnow required asArray<{ name: string; color?: string }>No
onRehydrateStorageor migration present in the persist config. The UI (e.g.,author.login.charAt(0)in columns.tsx) directly accesses the new structure without defensive checks.Existing installations have cached items where
authoris still a string orlabelsis missing. On first render after upgrade (beforerefreshDatacompletes), components will crash trying to call.charAt()on a string or undefined.Fix before shipping—existing users are at risk. Your suggested mitigations (storage key bump,
onRehydrateStoragemigration, or backward-compatible unions) are sound; the codebase already usesonRehydrateStoragein kanban.ts and migration patterns in auth.ts, so precedent exists.🤖 Prompt for AI Agents