Evaluate objective in C #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
requested changes
May 31, 2022
There was a problem hiding this comment.
awesome, great work @HenrikMettler!!1 🚀
i left a couple of comments that should be addressed before merging.
cgp/cartesian_graph.py
Outdated
Comment on lines
461
to
462
| "function_name can not be substring of filename, due to function declaration" | ||
| "consistency checks" |
There was a problem hiding this comment.
Suggested change
| "function_name can not be substring of filename, due to function declaration" | |
| "consistency checks" | |
| "function_name can not be substring of filename" |
maybe just shorten to this, since it's anyway hard to understand
There was a problem hiding this comment.
Looking at this again, maybe it is easiest to just remove the ability to set function_name and filename? Then we don't have to worry about this check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some applications, one might want to evaluate fitness in C. Here
CartesianGraphis extended with a functionto_cwhich writes the computational graph into a C-module. An example is provided which performs L2 regression on a simple target function.Note: Due to a late api change (writing files instead of returning strings) the test is currently not working - I left it as commented out code since large junks of it should be reusable with reading from generated files