Empty strings now returns error cause its not valid XML

Fixes Leonidas-from-XIV#343
Hannes-Magnusson-CK · Mar 22, 2017 · b9b44e0 · b9b44e0
1 parent 8374f68
commit b9b44e0
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 11 deletions.
diff --git a/lib/bom.js b/lib/bom.js
diff --git a/lib/builder.js b/lib/builder.js
diff --git a/lib/defaults.js b/lib/defaults.js
diff --git a/lib/parser.js b/lib/parser.js
diff --git a/lib/processors.js b/lib/processors.js
diff --git a/lib/xml2js.js b/lib/xml2js.js
diff --git a/src/parser.coffee b/src/parser.coffee
@@ -237,8 +237,8 @@ class exports.Parser extends events.EventEmitter
     try
       str = str.toString()
       if str.trim() is ''
-        @emit "end", null
-        return true
+        @emit 'error', new Error "Empty string is not valid XML"
+        return
 
       str = bom.stripBOM str
       if @options.async

diff --git a/test/parser.test.coffee b/test/parser.test.coffee
@@ -254,8 +254,11 @@ module.exports =
   'test empty tag result specified null': skeleton(emptyTag: null, (r) ->
     equ r.sample.emptytest[0], null)
 
-  'test invalid empty XML file': skeleton(__xmlString: ' ', (r) ->
-    equ r, null)
+  'test invalid empty XML file': (test) ->
+    x2js = new xml2js.Parser()
+    x2js.parseString '', (err, r) ->
+      assert.notEqual err, null
+      test.finish()
 
   'test enabled normalizeTags': skeleton(normalizeTags: true, (r) ->
     console.log 'Result object: ' + util.inspect r, false, 10