Added Queue column to RecurringJobsPage#1190
Conversation
This is untested code, but should work in theory. Fixes HangfireIO#1189
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
=========================================
Coverage ? 68.25%
=========================================
Files ? 155
Lines ? 5116
Branches ? 1075
=========================================
Hits ? 3492
Misses ? 1473
Partials ? 151Continue to review full report at Codecov.
|
Never messed with a cshtml file before.
|
Thanks for your PR! Would you mind to commit updated |
|
I think that should do it. |
|
@pieceofsummer, merging? For 1.6.20 ( |
|
@odinserj this shouldn't break anything, but it is not an urgent change. We might first merge it into |
|
@pieceofsummer, sounds good! |
|
I don't have the time to add it in this pull request, but #1194 might be equally as easy to implement. |
|
@Deantwo unfortunately, it won’t be as easy. There’s no Queue field associated with the Processing state, so it would require either adding it, or extracting from the previous Enqueued state. |
|
@pieceofsummer nevermind then. Issue just seemed very similar. |
|
So, is this being merged? Or do I need to change anything? |
|
What changed to make those tests fail? I was even missing this feature yesterday. |
|
This isn't getting merged because it would make it more obvious there is a big issue with recurring jobs and queues? |
This is untested code, but should work in theory.
Added a Queue column to the list of RecurringJobs on the RecurringJobsPage of the dashboard.
Fixes #1189
Might help with issues like #1149 too