fix(MicMute): Correct toggling mute button on Teams and Zoom#349
Open
kloudwrangler wants to merge 1 commit intoHammerspoon:masterfrom
Open
fix(MicMute): Correct toggling mute button on Teams and Zoom#349kloudwrangler wants to merge 1 commit intoHammerspoon:masterfrom
kloudwrangler wants to merge 1 commit intoHammerspoon:masterfrom
Conversation
kloudwrangler
changed the title
kloudwrangler
changed the title
kloudwrangler
changed the title
kloudwrangler
force-pushed
the
fix-micmute-toggle-button
branch
2 times, most recently
from
04743f1 to
17835fd
Compare
Corrects the menu item names used to mute/unmute audio in Zoom as they are case-sensitive by making a regex that is case insensitive. This resolves issues where the script fails to correctly toggle the mute state due to changes in application menu. Also changes the way the Microsoft teams app is found due to Teams change in bundle id.
kloudwrangler
force-pushed
the
fix-micmute-toggle-button
branch
from
17835fd to
e683256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the menu item names used to mute/unmute audio in Zoom as they are case-sensitive, resolving issues where the script fails to correctly toggle the mute state. Also changes the way the Microsoft teams app is found due to Teams change in bundle id.
Fixes #313